[PATCH v2] cmd: Handle CONFIG_(SPL_|TPL_)ENV_SUPPORT for toggling nvedit object

Wolfgang Denk wd at denx.de
Sun Feb 2 14:51:55 CET 2020


Dear Nathan,

In message <20200202130227.7755-1-nathan at nathanrossi.com> you wrote:
> When CONFIG_SPL_ENV_SUPPORT is disabled, nvedit was still being included
> as part of the build. Use the CONFIG_ENV_SUPPORT, CONFIG_SPL_ENV_SUPPORT
> or CONFIG_TPL_ENV_SUPPORT values to enable/disable the inclusion of
> nvedit.

Why should the availability of these commands depend on any of these
settings?  I think this is wrong - whether someone wants to have
environment commands in SPL or TPM is an independent decision. You
must not dictate it in such a way for all users.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Experience is that marvelous thing that enable  you  to  recognize  a
mistake when you make it again.                   - Franklin P. Jones


More information about the U-Boot mailing list