[PATCH v2 1/4] clock_imx8mq: Delete not used init_usb_clk()

Jon Nettleton jon at solid-run.com
Mon Feb 3 09:47:32 CET 2020


On Mon, Jan 27, 2020 at 2:16 PM Peng Fan <peng.fan at nxp.com> wrote:
>
> > Subject: Re: [PATCH v2 1/4] clock_imx8mq: Delete not used init_usb_clk()
> >
> > Hi Anatolij,
> >
> > On Thu, Jan 23, 2020 at 11:43 AM Anatolij Gustschin <agust at denx.de> wrote:
> > >
> > > On Thu, 23 Jan 2020 10:20:14 -0300
> > > Pedro Jardim jardim.c.pedro at gmail.com wrote:
> > >
> > > > Function init_usb_clk() is not used anywhere, so it can simply be deleted.
> > > > This was detected by the following sparse warning:
> > > >
> > > > arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no previous
> > > > prototype  for ‘init_usb_clk’ [-Wmissing-prototypes]  void
> > > > init_usb_clk(void)
> > >
> > > Cc'ing Peng. Maybe this was in preparation for adding USB support ?
> >
> > Unfortunately i.MX8M USB support has been pending for a long time.
> >
> > I prefer if we could get rid of this unused code and then bring this back when
> > USB support comes in.
>
> Not sure whether TI guys have done the cadence USB support.
>
> Previously Sherry did some usb work, but TI guys take over that.
>
> After the usb IP support ready, I or someone could start support usb for i.MX8MQ.
>
> For now, the function could be dropped.
>
> Thanks,
> Peng.

I have a working port of the Linux usb phy driver for the iMX8MQ
already.  I think the only piece that is missing to use dwc3-generic
for iMX8MQ is the common clk driver.  Has anyone started work on this?

-Jon


More information about the U-Boot mailing list