[PATCH v3 1/4] serial: ns16550: Support run-time configuration

Bin Meng bmeng.cn at gmail.com
Mon Feb 3 11:28:22 CET 2020


Hi Simon,

On Mon, Feb 3, 2020 at 10:34 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 10:29 AM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > On Fri, Dec 20, 2019 at 8:58 AM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > At present this driver uses an assortment of CONFIG options to control
> > > how it accesses the hardware. This is painful for platforms that are
> > > supposed to be controlled by a device tree or a previous-stage bootloader.
> > >
> > > Add a new CONFIG option to enable fully dynamic configuration. This
> > > controls register spacing, size, offset and endianness.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > > Changes in v3:
> > > - Rewrite the conditional logic to a fix a bug and match serial_xx_shift()
> > > - Add a separate flag for whether to use endian-aware out() functions
> > >
> > > Changes in v2:
> > > - runtime -> run-time
> > > - Enable run-time config for slimbootloader too
> > > - Improve Kconfig help based on Bin's comments
> > > - Use ns16550 in patch subject
> > >
> > >  drivers/serial/Kconfig   | 21 ++++++++++++++
> > >  drivers/serial/ns16550.c | 59 ++++++++++++++++++++++++++++++++++------
> > >  include/ns16550.h        | 16 ++++++++++-
> > >  3 files changed, 87 insertions(+), 9 deletions(-)
> > >
> >
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> applied to u-boot-x86, thanks!

This patch unfortunately breaks lots of platforms. See build log here:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=152&view=results

Could you please post a fix patch that could be squashed into this
patch? This patch is already applied in u-boot-x86/master.

Regards,
Bin


More information about the U-Boot mailing list