[PATCH v2 1/4] clock_imx8mq: Delete not used init_usb_clk()

[Peng Fan]

> Subject: Re: [PATCH v2 1/4] clock_imx8mq: Delete not used init_usb_clk()
> 
> 
> 
> On 27/01/20 6:46 PM, Peng Fan wrote:
> >> Subject: Re: [PATCH v2 1/4] clock_imx8mq: Delete not used
> >> init_usb_clk()
> >>
> >> Hi Anatolij,
> >>
> >> On Thu, Jan 23, 2020 at 11:43 AM Anatolij Gustschin <agust at denx.de>
> wrote:
> >>>
> >>> On Thu, 23 Jan 2020 10:20:14 -0300
> >>> Pedro Jardim jardim.c.pedro at gmail.com wrote:
> >>>
> >>>> Function init_usb_clk() is not used anywhere, so it can simply be
> deleted.
> >>>> This was detected by the following sparse warning:
> >>>>
> >>>> arch/arm/mach-imx/imx8m/clock_imx8mq.c:377:6: warning: no
> previous
> >>>> prototype  for ‘init_usb_clk’ [-Wmissing-prototypes]  void
> >>>> init_usb_clk(void)
> >>>
> >>> Cc'ing Peng. Maybe this was in preparation for adding USB support ?
> >>
> >> Unfortunately i.MX8M USB support has been pending for a long time.
> >>
> >> I prefer if we could get rid of this unused code and then bring this
> >> back when USB support comes in.
> >
> > Not sure whether TI guys have done the cadence USB support.
> 
> I guess you are talking about Cadence USB3 driver. Marek already merged the
> support. Please find the corresponding commits below:
> 
> f69257baa8 usb: composite: add BOS descriptor support to composite
> framework
> d80effb184 usb: gadget: Add gadget_is_cdns3() macro a9ca4193bd usb:
> cdns3: Add TI wrapper driver for CDNS USB3 controller 927c22b0da usb:
> cdns3: gadget: Implement udc_set_speed() callback 7e91f6ccdc usb: Add
> Cadence USB3 host and gadget driver 8d94e184ff usb: udc: Introduce
> ->udc_set_speed() method
> 77dcbdf3c1 usb: gadget: Add match_ep() op to usb_gadget_ops
> c93e305af7 bitmaps: import for_each_set_bit() macro
> c37f594280 list: import list_first_entry_or_null()

Great.

Then I think better keep the function.

Thanks,
Peng.

> 
> Thanks and regards,
> Lokesh
> 
> >
> > Previously Sherry did some usb work, but TI guys take over that.
> >
> > After the usb IP support ready, I or someone could start support usb for
> i.MX8MQ.
> >
> > For now, the function could be dropped.
> >
> > Thanks,
> > Peng.
> >