[PATCH 2/3] watchdog: omap_wdt: Fix WDT reloading

Lokesh Vutla lokeshvutla at ti.com
Mon Feb 3 15:26:30 CET 2020

On 24/01/20 10:14 AM, Marek Vasut wrote:
> The watchdog timer value was never updated in the hardware by this
> driver, so the watchdog triggered on some random stale value that
> was left in the hardware. The TI SPRUH37C says, quote:
> Modifying Timer Count/Load Values and Prescaler Setting
>   ...
>   After a write access, the load register value and prescaler ratio
>   registers are updated immediately, but new values are considered
>   only after the next consecutive counter overflow or after a new
>   trigger command (the WDT_WTGR register).
> This means at least one trigger must happen. The driver probably
> depended on someone calling it's .reset() callback, however that
> is not guaranteed e.g. if the WDT operates without servicing.
> Add this missing trigger.
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Grygorii Strashko <grygorii.strashko at ti.com>
> Cc: Sam Protsenko <semen.protsenko at linaro.org>
> Cc: Suniel Mahesh <sunil.m at techveda.org>

Reviewed-by: Lokesh Vutla <lokeshvutla at ti.com>

Thanks and regards,

More information about the U-Boot mailing list