[PATCH v2 1/3] gpio: intel_gpio: Pass pinctrl device to pcr_clrsetbits32()

[Bin Meng]

On Mon, Feb 3, 2020 at 6:48 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner
> <wolfgang.wallner at br-automation.com> wrote:
> >
> > The function pcr_clrsetbits32() expects a device with a P2SB parent
> > device. In intel_gpio_direction_output() and intel_gpio_set_value()
> > the device 'dev' is passed to pcr_clrsetbits32(), which is a
> > gpio-controller with a device 'pinctrl' as parent. This does not match
> > the expectations of pcr_clrsetbits32(). But the 'pinctrl' device has a
> > P2SB as parent.
> >
> > Pass the 'pinctrl' device instead of the 'dev' device to
> > pcr_clrsetbits32().
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> >
> > ---
> >
> > Changes in v2:
> > - Fixed typo in the commit description
> > - Fixed the same error in both intel_gpio_direction_output() and
> > intel_gpio_set_value() (Thanks to Bin Meng for catching this)
> > - Reworded commit description
> >
> >  drivers/gpio/intel_gpio.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!