[PATCH v2 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

Bin Meng bmeng.cn at gmail.com
Tue Feb 4 03:59:03 CET 2020


On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner
<wolfgang.wallner at br-automation.com> wrote:
>
> Fix the following in intel_gpio_get_value():
>
>  * The value of the register is contained in the variable 'reg', not in
>    'mode'. The variable 'mode' contains only the configuration whether
>    the gpio is currently an input or an output.
>
>  * The correct bitmasks for the input and output value are
>    PAD_CFG0_RX_STATE and PAD_CFG0_TX_STATE.
>    Use them instead of the currently used PAD_CFG0_RX_STATE_BIT and
>    PAD_CFG0_TX_STATE_BIT.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
>
> Changes in v2: None
>
>  drivers/gpio/intel_gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list