[PATCH v3 04/12] reset: Add generic reset driver

Sean Anderson seanga2 at gmail.com
Tue Feb 4 15:14:37 CET 2020


On 2/4/20 6:06 AM, Bin Meng wrote:
> Hi Sean,
> 
> On Mon, Feb 3, 2020 at 4:01 AM Sean Anderson <seanga2 at gmail.com> wrote:
>> +Required properties:
>> +- compatible: should contain "syscon-reset"
> 
> Shouldn't we follow the same generic "syscon-reboot" device bindings
> defined in the Linux kernel?
> See Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml

This is a different driver. That driver is already in u-boot as
UCLASS_SYSRESET, but this driver is for UCLASS_RESET. I modeled this one
off syscon-reboot.

> nits: this line should not be deleted.

Ok, will restore for v4.

--Sean


More information about the U-Boot mailing list