[PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static
peng.fan at nxp.com
Wed Feb 5 08:28:49 CET 2020
> Subject: Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static
> On 31/01/20 3:55 am, Simon Goldschmidt wrote:
> > Am 30.01.2020 um 23:21 schrieb Jaehoon Chung:
> >> Hi Simon,
> >> On 1/29/20 11:16 PM, Simon Goldschmidt wrote:
> >>> On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung
> >>> <jh80.chung at samsung.com> wrote:
> >>>> On 1/24/20 8:52 PM, Faiz Abbas wrote:
> >>>>> Expose sdhci_init() as non-static.
> >>>> Does it need to change to non-static?
> >>> And even if it needs to, can we have a reason *why* in the commit
> >>> message?
> >> When i read entire your series, it seems that doesn't need to change
> >> to non-static.
> >> All of change that touched MMC code are only for your board.
> >> I don't know Peng's opinion, but it's not my prefer.
> > +1!
> > We need to keep the core code clean of such hacks in order to keep the
> > size small for constrained targets!
> Peng can you comment on this?
Just one more question, does kernel has same issue, how resolved?
Could U-Boot follow similar approach?
Actually I am fine with platform specific approach , considering
your platform issue.
But since Simon and Jaehoon has concerns, not sure whether
Simon and Jaehoon have good ideas.
> Jaehoon, I am not sure what you mean by "it doesn't need to change to
> non-static". How would I call the sdhci_init() function from my platform driver
More information about the U-Boot