[PATCH 1/2] board: solidrun lx2160a-cex7: new board

[Priyanka Jain (OSS)]

>-----Original Message-----
>From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Baruch Siach
>Sent: Thursday, February 6, 2020 5:16 PM
>To: Priyanka Jain <priyanka.jain at nxp.com>
>Cc: u-boot at lists.denx.de; Rabeeh Khoury <rabeeh at solid-run.com>
>Subject: Re: [PATCH 1/2] board: solidrun lx2160a-cex7: new board
>
>Hi Priyanka,
>
>On Thu, Jan 23, 2020 at 11:42:56AM +0200, Baruch Siach wrote:
>> On Thu, Jan 23, 2020 at 09:25:29AM +0000, Priyanka Jain wrote:
>> > >-----Original Message-----
>> > >From: Baruch Siach <baruch at tkos.co.il>
>> > >Sent: Wednesday, December 4, 2019 6:59 PM
>> > >To: Priyanka Jain <priyanka.jain at nxp.com>
>> > >Cc: u-boot at lists.denx.de; Rabeeh Khoury <rabeeh at solid-run.com>; Jon
>> > >Nettleton <jon at solid-run.com>; Baruch Siach <baruch at tkos.co.il>
>> > >Subject: [PATCH 1/2] board: solidrun lx2160a-cex7: new board
>> > >
>> > >Add board level support code for the SolidRun LX2160A based
>> > >COM-Express
>> > >7 system.
>> > >
>> > >Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>> > >---
>> > This patch has  below compilation warning. Kindly fix.
>> >    aarch64:  +   lx2160acex7_tfa
>> > +board/solidrun/lx2160acex7/lx2160acex7.c: In function 'uart_get_clock':
>> > +board/solidrun/lx2160acex7/lx2160acex7.c:50:18: error: implicit
>> > +declaration of function 'get_serial_clock'; did you mean
>> > +'uart_get_clock'? [-Werror=implicit-function-declaration]
>> > +  serial0.clock = get_serial_clock();
>> > +                  ^~~~~~~~~~~~~~~~
>> > +                  uart_get_clock
>> > +cc1: all warnings being treated as errors
>> > +make[2]: *** [board/solidrun/lx2160acex7/lx2160acex7.o] Error 1
>> > +make[1]: *** [board/solidrun/lx2160acex7] Error 2
>> > +make: *** [sub-make] Error 2
>>
>> Thanks for your review.
>>
>> This build error is because of commit d96c26040e901 ("common: Move
>> clock functions into a new file"). clock_legacy.h include in now
>> missing. I'll rebase the patches on current master and post an update.
>
>It turns out that adding clock_legacy.h is not enough. The board does not
>boot current U-Boot master with nothing shown on the console. Do you have
>any idea what LX2160A related code change might have caused that?
>
>Thanks,
>baruch
>
>
These might be related to UART related changes done by Vabhav for lx2160ardb.
Adding Vabhav to provide the details. Meanwhile, you can also check changes via git log.

Regards
Priyanka