[PATCH v2 3/7] cmd: env: check real location for env info command

Simon Glass sjg at chromium.org
Tue Feb 11 00:13:50 CET 2020


On Mon, 10 Feb 2020 at 10:01, Patrick Delaunay <patrick.delaunay at st.com> wrote:
>
> Check the current ENV location, dynamically provided by the weak
> function env_get_location to be sure that the environment can be
> persistent.
>
> The compilation flag ENV_IS_IN_DEVICE is not enough when the board
> dynamically select the available storage location (according boot
> device for example).
>
> This patch solves issue for stm32mp1 platform, when the boot device
> is USB.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
> Changes in v2:
> - update prototype in env_internal.h  as done in
>   "env: add prototypes for weak function"
> - remove comment change in env.c (implementation information)
> - move env_location declaration
>
>  cmd/nvedit.c           | 15 ++++++++++++---
>  include/env_internal.h | 11 +++++++++++
>  2 files changed, 23 insertions(+), 3 deletions(-)

Definitely we need some more tests in the area of the environment.

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list