[PATCH 1/9] dma-mapping: fix the prototype of dma_map_single()
masahiroy at kernel.org
Tue Feb 11 16:18:07 CET 2020
On Wed, Feb 5, 2020 at 9:17 AM Simon Glass <sjg at chromium.org> wrote:
> On Tue, 4 Feb 2020 at 04:09, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
> > Make dma_map_single() return the dma address, and remove the
> > pointless volatile.
> > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> > ---
> > arch/arm/include/asm/dma-mapping.h | 5 +++--
> > arch/nds32/include/asm/dma-mapping.h | 5 +++--
> > arch/riscv/include/asm/dma-mapping.h | 5 +++--
> > arch/x86/include/asm/dma-mapping.h | 5 +++--
> > 4 files changed, 12 insertions(+), 8 deletions(-)
> Reviewed-by: Simon Glass <sjg at chromium.org>
> But please can you add a full function comment in the header files?
I can comment them, but it is tedious to duplicate
exactly the same description to all of these architectures.
So, my next plan is to merge them into
then make it a single point of comments.
Each arch's <asm/dma-mapping.h> can simply wraps
It would be beyond the scope of this series
(since my main motivation is fix the mmc/sdhci bug).
So, I want to just let this series go in.
After it lands, I can factoring them out,
and add some comments.
More information about the U-Boot