[PATCH 1/1] test: log functions with CONFIG_LOG=n

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Feb 11 19:17:41 CET 2020


On 2/11/20 6:14 PM, Simon Glass wrote:
> Hi Heinrich,
>
> On Mon, 10 Feb 2020 at 22:36, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> If CONFIG_LOG=n, we still expect output for log_err(), log_warning(),
>> log_notice(), log_info() and in case of DEBUG=1 also for log_debug().
>>
>> Provide unit tests verifying this.
>>
>> The tests depend on:
>>
>>          CONFIG_CONSOLE_RECORD=y
>>          CONFIG_LOG=n
>>
>> It may be necessary to increase the value of CONFIG_SYS_MALLOC_F_LEN to
>> accommodate CONFIG_CONSOLE_RECORD=y.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>   MAINTAINERS           |   2 +-
>>   include/test/suites.h |   1 +
>>   test/Makefile         |   2 +-
>>   test/cmd_ut.c         |   6 ++
>>   test/log/Makefile     |   4 ++
>>   test/log/nolog_test.c | 147 ++++++++++++++++++++++++++++++++++++++++++
>>   6 files changed, 160 insertions(+), 2 deletions(-)
>>   create mode 100644 test/log/nolog_test.c
>>
>
> Looks good - but can you please look at u-boot-dm/master, e.g. this one:
>
> 400175b0a7 test: Add a way to check each line of console output
>
> as we don't want to call membuff directory.

I found your patch in WIP/11Feb2020. Thanks for the hint.

Best regards

Heinrich


More information about the U-Boot mailing list