[PATCH v2 1/1] common/console.c: discard volatile

Tom Rini trini at konsulko.com
Thu Feb 13 23:12:39 CET 2020


On Wed, Feb 12, 2020 at 06:23:49PM +0100, Heinrich Schuchardt wrote:

> Avoid errors of like
> 
> common/console.c: In function ‘console_record_reset’:
> common/console.c:615:16: error: passing argument 1 of ‘membuff_purge’
> discards ‘volatile’ qualifier from pointer target type
> [-Werror=discarded-qualifiers]
>   615 |  membuff_purge(&gd->console_out);
>       |                ^~~~~~~~~~~~~~~~
> 
> by casting to non-volatile.
> 
> The volatile property stems from declarations like
> 
> arch/arm/include/asm/global_data.h:114:
> 
> But there is no need to treat gd->console_out and gd->console_in as
> volatile in the context of common/console.c.
> 
> Fixes: b612312816ff ("console: Add a function to read a line of the output / eof")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200213/76ed665f/attachment.sig>


More information about the U-Boot mailing list