[PATCH] usb: dwc3: Check that the request is valid in dwc3_gadget_giveback()

Vignesh Raghavendra vigneshr at ti.com
Fri Feb 14 13:23:28 CET 2020


From: Jean-Jacques Hiblot <jjhiblot at ti.com>

This fixes potential issues reported by klokworks:
Pointer 'req' returned from call to function 'next_request' at line 531 and
538 may be NULL and will be dereferenced in dwc3_gadget_giveback()

Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>
---
 drivers/usb/dwc3/gadget.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 4353dffb6b12..12de3b1da663 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -227,6 +227,9 @@ void dwc3_gadget_giveback(struct dwc3_ep *dep, struct dwc3_request *req,
 {
 	struct dwc3			*dwc = dep->dwc;
 
+	if (!req)
+		return;
+
 	if (req->queued) {
 		dep->busy_slot++;
 		/*
-- 
2.25.0



More information about the U-Boot mailing list