[PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

[Tom Rini]

On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote:
> Hi Tom,
> Cc: Masahiro Yamada
> 
> On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> > The image.h header can be used fairly widely in U-Boot builds.  We
> > cannot use u32 here as it may be used in cases where we don't have that
> > typedef available and don't want to expose it either.  Use uint instead
> > here.
> > 
> > Cc: Eugeniu Rosca <roscaeugeniu at gmail.com>
> > Cc: Sam Protsenko <joe.skb7 at gmail.com>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  include/image.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/image.h b/include/image.h
> > index b316d167d8d7..1dc3b48d8689 100644
> > --- a/include/image.h
> > +++ b/include/image.h
> > @@ -1425,9 +1425,9 @@ int android_image_get_ramdisk(const struct andr_img_hdr *hdr,
> >  			      ulong *rd_data, ulong *rd_len);
> >  int android_image_get_second(const struct andr_img_hdr *hdr,
> >  			      ulong *second_data, ulong *second_len);
> > -bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, u32 *size);
> > -bool android_image_get_dtb_by_index(ulong hdr_addr, u32 index, ulong *addr,
> > -				    u32 *size);
> > +bool android_image_get_dtbo(ulong hdr_addr, ulong *addr, uint *size);
> > +bool android_image_get_dtb_by_index(ulong hdr_addr, uint index, ulong *addr,
> > +				    uint *size);
> 
> While I think the change is harmless and brings some consistency and
> visual comfort when reviewing the types employed in 'include/image.h',
> I can hardly imagine a real-life breakage introduced by u32 in
> 'include/image.h'.

I ran in to this in practice with
http://patchwork.ozlabs.org/project/uboot/list/?series=155410&state=*
applied.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200216/42f6ca21/attachment.sig>