[PATCH] usb: dwc3: Check that the request is valid in dwc3_gadget_giveback()

[Vignesh Raghavendra]

On 15/02/20 12:03 am, Marek Vasut wrote:
> On 2/14/20 1:23 PM, Vignesh Raghavendra wrote:
>> From: Jean-Jacques Hiblot <jjhiblot at ti.com>
>>
>> This fixes potential issues reported by klokworks:
>> Pointer 'req' returned from call to function 'next_request' at line 531 and
>> 538 may be NULL and will be dereferenced in dwc3_gadget_giveback()
> 
> Shouldn't you rather handle the issue in dwc3_remove_requests() ?
> Also, please explain what conditions trigger this issue, i.e. when req
> becomes NULL.
> 

There is already a check for list_empty() before calling next_request()
in dwc3_remove_requests() which makes sure that 'req' will not be NULL.
So this report is a false positive.

Please ignore the patch.. Sorry for the trouble

-- 
Regards
Vignesh