[PATCH] misc: k3_avs: Fix possible NULL pointer deference

Keerthy j-keerthy at ti.com
Mon Feb 17 05:44:28 CET 2020



On 14/02/20 5:52 pm, Vignesh Raghavendra wrote:
> Its possible that k3_avs_priv is NULL because the driver may not have
> been probed yet. Therefore check if pointer is valid before
> dereferencing it.

Reviewed-by: Keerthy <j-keerthy at ti.com>

> 
> Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>
> ---
>   drivers/misc/k3_avs.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c
> index c19c3c0646b7..adaf75b7165d 100644
> --- a/drivers/misc/k3_avs.c
> +++ b/drivers/misc/k3_avs.c
> @@ -190,6 +190,10 @@ int k3_avs_notify_freq(int dev_id, int clk_id, u32 freq)
>   	struct k3_avs_privdata *priv = k3_avs_priv;
>   	struct vd_data *vd;
>   
> +	/* Driver may not be probed yet */
> +	if (!priv)
> +		return -EINVAL;
> +
>   	for (vd = priv->vd_config->vds; vd->id >= 0; vd++) {
>   		if (vd->dev_id != dev_id || vd->clk_id != clk_id)
>   			continue;
> 


More information about the U-Boot mailing list