[PATCH 1/1] clk: meson-g12a: missing break

Neil Armstrong narmstrong at baylibre.com
Mon Feb 17 09:42:37 CET 2020


On 15/02/2020 21:10, Heinrich Schuchardt wrote:
> Add missing break for CLKID_PCIE_PLL in switch statement.
> 
> Reported by CppCheck.
> 
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Fixes: 08e09c263fdf ("clk: meson-g12a: Add PCIE PLL support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> Looking at the code it seems obvious that something is wrong in commit
> 08e09c263fdf but I have no board for testing.
> ---
> 
>  drivers/clk/meson/g12a.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 686d94ebfe..cada80e6b5 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -804,6 +804,7 @@ static ulong meson_clk_get_rate_by_id(struct clk *clk, unsigned long id)
>  		break;
>  	case CLKID_PCIE_PLL:
>  		rate = meson_pcie_pll_get_rate(clk);
> +		break;
>  	case CLKID_VPU_0:
>  		rate = meson_div_get_rate(clk, CLKID_VPU_0_DIV);
>  		break;
> --
> 2.25.0
> 

Thanks,
Acked-by: Neil Armstrong <narmstrong at baylibre.com>

Applied to u-boot-amlogic

Neil


More information about the U-Boot mailing list