[PATCH 1/1] stm32mp1: rng: remove superfluous assignment

Sughosh Ganu sughosh.ganu at linaro.org
Tue Feb 18 11:22:37 CET 2020


On Sun, 16 Feb 2020 at 14:41, Heinrich Schuchardt <xypron.glpk at gmx.de>
wrote:

> We should not assign a value that is overwritten before use.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>

Acked-by: Sughosh Ganu <sughosh.ganu at linaro.org>


> ---
>  drivers/rng/stm32mp1_rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c
> index dab3b995eb..e0f0a66c6e 100644
> --- a/drivers/rng/stm32mp1_rng.c
> +++ b/drivers/rng/stm32mp1_rng.c
> @@ -33,7 +33,7 @@ struct stm32_rng_platdata {
>
>  static int stm32_rng_read(struct udevice *dev, void *data, size_t len)
>  {
> -       int retval = 0, i;
> +       int retval, i;
>         u32 sr, count, reg;
>         size_t increment;
>         struct stm32_rng_platdata *pdata = dev_get_platdata(dev);
> --
> 2.25.0
>
>


More information about the U-Boot mailing list