[PATCH v3 07/11] mmc: sdhci: use lower_32_bit2() and upper_32_bits() for setting adma_addr
Jaehoon Chung
jh80.chung at samsung.com
Tue Feb 18 12:19:59 CET 2020
On 2/14/20 4:40 PM, Masahiro Yamada wrote:
> Use {lower,upper}_32_bits() instead of the combination of cast
> and shift.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/mmc/sdhci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index b4713e7b9bba..fefe81016eb1 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -153,9 +153,10 @@ static void sdhci_prepare_dma(struct sdhci_host *host, struct mmc_data *data,
> } else if (host->flags & (USE_ADMA | USE_ADMA64)) {
> sdhci_prepare_adma_table(host, data);
>
> - sdhci_writel(host, (u32)host->adma_addr, SDHCI_ADMA_ADDRESS);
> + sdhci_writel(host, lower_32_bits(host->adma_addr),
> + SDHCI_ADMA_ADDRESS);
> if (host->flags & USE_ADMA64)
> - sdhci_writel(host, (u64)host->adma_addr >> 32,
> + sdhci_writel(host, upper_32_bits(host->adma_addr),
> SDHCI_ADMA_ADDRESS_HI);
> }
>
>
More information about the U-Boot
mailing list