[PATCH v2] dm: core: Move "/chosen" and "/firmware" node scan

Patrick DELAUNAY patrick.delaunay at st.com
Tue Feb 18 14:21:06 CET 2020


Hi,

> From: Simon Glass <sjg at chromium.org>
> Sent: lundi 17 février 2020 04:56
> 
> Hi Patrick,
> 
> On Thu, 13 Feb 2020 at 11:48, Patrick Delaunay <patrick.delaunay at st.com>
> wrote:
> >
> > Use the new function dm_scan_fdt_ofnode_path() to scan all the nodes
> > which aren't devices themselves but may contain some:
> > - "/chosen"
> > - "/clocks"
> > - "/firmware"
> >
> > The patch removes the strcmp call in recursive function
> > dm_scan_fdt_live() and also corrects a conflict with the 2 applied
> > patches in the commit 1712ca21924b ("dm: core: Scan /firmware node by
> > default") and in the commit 747558d01457 ("dm: fdt: scan for devices
> > under /firmware too"): the subnodes of "/firmware" (optee for example)
> > are bound 2 times.
> >
> > For example the dm tree command result on STM32MP1 is:
> >
> > STM32MP> dm tree
> >  Class     Index  Probed  Driver                Name
> >  -----------------------------------------------------------
> >  root          0  [ + ]   root_driver           root_driver
> >  firmware      0  [   ]   psci                  |-- psci
> >  sysreset      0  [   ]   psci-sysreset         |   `-- psci-sysreset
> >  simple_bus    0  [ + ]   generic_simple_bus    |-- soc
> > ...
> >  tee           0  [ + ]   optee                 |-- optee
> > ...
> >  tee           1  [   ]   optee                 `-- optee
> >
> > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> > ---
> >
> > Changes in v2:
> > - update commit message (Serie-cc => Series-cc)
> >
> >  drivers/core/root.c | 52
> > +++++++++++++++------------------------------
> >  1 file changed, 17 insertions(+), 35 deletions(-)
> 
> 
> This looks good to me, but please can you address the test failure (make
> qcheck)?

I forget to execute it, sorry.

Work in progress....

 
> Regards,
> Simon

Patrick


More information about the U-Boot mailing list