[PATCH v2 09/21] arm: socfpga: Define SMC function identifiers for PSCI SiP services

[Marek Vasut]

On 2/19/20 1:25 PM, chee.hong.ang at intel.com wrote:
[...]
> +++ b/include/linux/intel-smc.h
> @@ -0,0 +1,374 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2017-2018, Intel Corporation

2020 ?

[...]

> + */
> +#define INTEL_SIP_SMC_RETURN_UNKNOWN_FUNCTION		0xFFFFFFFF
> +#define INTEL_SIP_SMC_STATUS_OK				0x0
> +#define INTEL_SIP_SMC_FPGA_CONFIG_STATUS_BUSY		0x1
> +#define INTEL_SIP_SMC_FPGA_CONFIG_STATUS_REJECTED       0x2
> +#define INTEL_SIP_SMC_FPGA_CONFIG_STATUS_ERROR		0x4
> +#define INTEL_SIP_SMC_REG_ERROR				0x5
> +#define INTEL_SIP_SMC_RSU_ERROR				0x7

Indent with tabs

[...]

> +/*
> + * Request INTEL_SIP_SMC_MBOX_SEND_CMD
> + *
> + * Sync call used by service driver at EL1 to send mailbox command to SDM
> + *
> + * Call register usage:
> + * a0 INTEL_SIP_SMC_MBOX_SEND_CMD
> + * a1 Mailbox command
> + * a2 64bit physical address pointer to command's arguments
> + * a3 Length of the argument
> + * a4 Urgent command enable = 1 / disable = 0
> + * a5 64bit physical address pointer to a buffer for receiving responses
> + * a6 Length of the buffer
> + *
> + * Return status
> + * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_RSU_ERROR.
> + * a1 Status of mailbox response
> + * a2 64bit physical address pointer to a buffer for receiving responses
> + * a3 Received length in the buffer
> + */
> +#define INTEL_SIP_SMC_FUNCID_MBOX_SEND_CMD     30
> +#define INTEL_SIP_SMC_MBOX_SEND_CMD \
> +	INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_MBOX_SEND_CMD)

Is this macro a function call or a value ?