[PATCH v2 2/3] mmc: sdhci: not return error when SDMA is not supported

[Minkyu Kang]

On 18/02/2020 10:25, Jaehoon Chung wrote:
> If Host controller doesn't support SDMA, it doesn't need to return
> error. Because it can be worked with PIO mode.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
> Reviewed-by: Peng Fan <peng.fan at nxp.com>
> ---
> Changelog on V2
> - Keep printf message instead of debug
> 
>  drivers/mmc/sdhci.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index 93c9049c5d..40bf2a5b2c 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -729,13 +729,12 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host,
>  	debug("%s, caps: 0x%x\n", __func__, caps);
>  
>  #ifdef CONFIG_MMC_SDHCI_SDMA
> -	if (!(caps & SDHCI_CAN_DO_SDMA)) {
> +	if ((caps & SDHCI_CAN_DO_SDMA)) {

seems to redundant braces

> +		host->flags |= USE_SDMA;
> +	} else {
>  		printf("%s: Your controller doesn't support SDMA!!\n",
>  		       __func__);
> -		return -EINVAL;
>  	}
> -
> -	host->flags |= USE_SDMA;
>  #endif
>  #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
>  	if (!(caps & SDHCI_CAN_DO_ADMA2)) {
> 

Reviewed-by: Minkyu Kang <mk7.kang at samsung.com>

Thanks,
Minkyu Kang.