[PATCH] global_data.h: make <asm-generic/global_data.h> self-contained

Masahiro Yamada masahiroy at kernel.org
Mon Feb 24 18:22:27 CET 2020

The compiler never knows what 'bd_t' is without including <asm/u-boot.h>.

By changing it to (struct bd_info), the compiler learns it is struct.

Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>

Maybe, we should replace 'bd_t' with 'struct bd_info' globally
by using coccinelle or something.

Linux coding style (Documentation/process/coding-style.rst)
apparently discourages typedef for cases like this.

 include/asm-generic/global_data.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
index 5d027329fe..d9e220cfe3 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -25,7 +25,7 @@
 #include <linux/list.h>
 typedef struct global_data {
-	bd_t *bd;
+	struct bd_info *bd;
 	unsigned long flags;
 	unsigned int baudrate;
 	unsigned long cpu_clk;		/* CPU clock in Hz!		*/

More information about the U-Boot mailing list