[PATCH] x86: Cache write back at 32-bit entry point

Bin Meng bmeng.cn at gmail.com
Fri Feb 28 06:26:49 CET 2020


Hi Aiden,

On Fri, Feb 28, 2020 at 12:54 PM Park, Aiden <aiden.park at intel.com> wrote:
>
> In a certain condition, invd causes cache coherence issue.
>   1. Pre-stage boot code passes memory address to U-Boot
>   2. The data of the memory address is still in data cache line
>   3. The invd marks data cache line as invalid without write back
>   4. U-Boot accesses the memory address
>   5. Data is invalid
>
> Therefore, wbinvd is recommended at the 32-bit entry point even though
> it consumes extra cpu clock cycles.
>
> Signed-off-by: Aiden Park <aiden.park at intel.com>
> ---
>  arch/x86/cpu/start.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

This is already fixed (reverted) in the x86 tree. Would you please double check?

Regards,
Bin


More information about the U-Boot mailing list