[PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

Andy Shevchenko andy.shevchenko at gmail.com
Fri Feb 28 09:46:53 CET 2020


On Fri, Feb 28, 2020 at 1:41 AM Simon Glass <sjg at chromium.org> wrote:
> On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:

> Could you take a look at the ACPI series?
>
> It was sent out about a month ago and has a refactor to this function.
>
> u-boot-dm/coral-working

There are tons of changes. Care to point what changes are more
important (generic to all x86)?

P.S. Briefly looking at the last ~30 patches I can say that the idea
looks good, implementation needs more work. For example, there is
'linux,name' property. Shouldn't be referred at all. Linux names and
other type of enumerations is utterly opaque to the outside world.

On top of that, I think we rather need to have a conversion layer than
putting some names inside DT, like \_SB_.GPO0 should be generated
automatically from DT node. That said, I don't like DT being polluted
with non-DT stuff.

Also, I'm not sure how your rework helps ARM (or any other
architecture) people with their approach to ACPI enabling (most of the
files are under x86).

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list