[PATCH v5 4/6] lib: rsa: generate additional parameters for public key

AKASHI Takahiro takahiro.akashi at linaro.org
Mon Jan 6 02:32:20 CET 2020


Simon,

On Fri, Dec 27, 2019 at 07:26:40PM -0700, Simon Glass wrote:
> On Tue, 17 Dec 2019 at 01:53, AKASHI Takahiro
> <takahiro.akashi at linaro.org> wrote:
> >
> > In the current implementation of FIT_SIGNATURE, five parameters for
> > a RSA public key are required while only two of them are essential.
> > (See rsa-mod-exp.h and uImage.FIT/signature.txt)
> > This is a result of considering relatively limited computer power
> > and resources on embedded systems, while such a assumption may not
> > be quite practical for other use cases.
> >
> > In this patch, added is a function, rsa_gen_key_prop(), which will
> > generate additional parameters for other uses, in particular
> > UEFI secure boot, on the fly.
> >
> > Note: the current code uses some "big number" routines from BearSSL
> > for the calculation.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > ---
> >  include/u-boot/rsa-mod-exp.h |  23 ++
> >  lib/rsa/Kconfig              |   3 +
> >  lib/rsa/Makefile             |   1 +
> >  lib/rsa/rsa-keyprop.c        | 725 +++++++++++++++++++++++++++++++++++
> >  4 files changed, 752 insertions(+)
> >  create mode 100644 lib/rsa/rsa-keyprop.c
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I think it would help to have the change log in each patch as well as
> the cover letter. If you use patman it will do this for you.

Ah, I didn't know that.
It will take some time to learn more about patman.

Thanks,
-Takahiro Akashi


More information about the U-Boot mailing list