[PATCH] video: fix Coverity missing break issue
Anatolij Gustschin
agust at denx.de
Mon Jan 6 23:00:38 CET 2020
Fix:
>>> CID 280902: Control flow issues (MISSING_BREAK)
>>> The case for value "VIDEO_BPP32" is not terminated
>>> by a 'break' statement.
Reported-by: Tom Rini <trini at konsulko.com>
Signed-off-by: Anatolij Gustschin <agust at denx.de>
---
drivers/video/vidconsole-uclass.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c
index 75c7e25095..6c0daa1ee5 100644
--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -144,12 +144,14 @@ u32 vid_console_color(struct video_priv *priv, unsigned int idx)
((colors[idx].g >> 2) << 5) |
((colors[idx].b >> 3) << 0);
}
+ break;
case VIDEO_BPP32:
if (CONFIG_IS_ENABLED(VIDEO_BPP32)) {
return (colors[idx].r << 16) |
(colors[idx].g << 8) |
(colors[idx].b << 0);
}
+ break;
default:
/*
* For unknown bit arrangements just support
--
2.17.1
More information about the U-Boot
mailing list