[PATCH 1/3] dtimg/am57xx_evm_defconfig: Rename dtimg to adtimg
Eugeniu Rosca
erosca at de.adit-jv.com
Tue Jan 7 18:13:58 CET 2020
Hi Simon,
On Tue, Jan 07, 2020 at 09:49:45AM -0700, Simon Glass wrote:
> On Tue, 24 Dec 2019 at 09:51, Eugeniu Rosca <roscaeugeniu at gmail.com> wrote:
> >
> > Rename the existing 'dtimg' command to 'adtimg', in order to:
> > - Suggest the Android origins and scope
> > - Be consistent with the upcoming 'abootimg' command (naming
> > suggested by Simon [*])
> >
> > The change in _not_ backward compatible, but its benefits outweigh its
> > downsides, given that we don't expect active users of 'dtimg' today.
> >
> > Perform the rename in several steps:
> > 1. Rename *.c file and Kconfig symbol. This should allow
> > 'git log --follow' to properly track the history of 'adtimg.c'
> > 2. 's/dtimg/adtimg/g' in the internal namespace of 'adtimg.c'
> >
> > ELF comparison [**] before and after shows no functional change.
> >
> > [*] https://patchwork.ozlabs.org/patch/1182212/#2291600
> > [**] diff -u <(objdump -d cmd/dtimg.o) <(objdump -d cmd/adtimg.o)
> >
> > Cc: Tom Rini <trini at konsulko.com>
> > Cc: Sam Protsenko <semen.protsenko at linaro.org>
> > Cc: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> > ---
> > cmd/Kconfig | 4 ++--
> > cmd/Makefile | 2 +-
> > cmd/{dtimg.c => adtimg.c} | 0
> > common/Makefile | 2 +-
> > configs/am57xx_evm_defconfig | 2 +-
> > configs/am57xx_hs_evm_defconfig | 2 +-
> > configs/am57xx_hs_evm_usb_defconfig | 2 +-
> > 7 files changed, 7 insertions(+), 7 deletions(-)
> > rename cmd/{dtimg.c => adtimg.c} (100%)
> >
>
> Reviewed-by: Simon Glass<sjg at chromium.org>
Happy new year and thank you very much for the review!
Do you see any blocking points in the other patches from this series?
- https://patchwork.ozlabs.org/patch/1215258/
- https://patchwork.ozlabs.org/patch/1215259/
If not, would you kindly provide your Reviewed-by signature?
This would unblock Sam with the recent 'abootimg' series:
- https://patchwork.ozlabs.org/cover/1215282/
This would also unblock me with some upcoming adtimg patches.
Thanks in advance for your feedback!
--
Best Regards,
Eugeniu
More information about the U-Boot
mailing list