[PATCH] Revert "dm: core: Scan "/firmware" node by default"

Simon Glass sjg at chromium.org
Wed Jan 8 18:39:56 CET 2020


Hi T,

On Tue, 7 Jan 2020 at 20:24, Thirupathaiah Annapureddy
<thiruan at linux.microsoft.com> wrote:
>
> Subnodes under "/firmware" node are scanned twice in dm_scan_fdt_node
> and dm_extended_scan_fdt. This patch removes the double scanning.
>
> This reverts commit 1712ca21924bff678f19fd3141f435408d23bdbf.
>
> Signed-off-by: Thirupathaiah Annapureddy <thiruan at linux.microsoft.com>
> ---
>  drivers/core/root.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/core/root.c b/drivers/core/root.c
> index e85643819e..daf7c61190 100644
> --- a/drivers/core/root.c
> +++ b/drivers/core/root.c
> @@ -342,14 +342,8 @@ int dm_extended_scan_fdt(const void *blob, bool pre_reloc_only)
>         }
>
>         ret = dm_scan_fdt_ofnode_path("/clocks", pre_reloc_only);
> -       if (ret) {
> -               debug("scan for /clocks failed: %d\n", ret);
> -               return ret;
> -       }
> -
> -       ret = dm_scan_fdt_ofnode_path("/firmware", pre_reloc_only);
>         if (ret)
> -               debug("scan for /firmware failed: %d\n", ret);
> +               debug("scan for /clocks failed: %d\n", ret);
>
>         return ret;
>  }
> --
> 2.24.1
>

I actually think it would be better to remove this from
dm_scan_fdt_node() since that function looks for f


More information about the U-Boot mailing list