[PATCH] mtd: rawnand: denali_dt: make the core clock optional

Marek Vasut marex at denx.de
Thu Jan 9 14:20:14 CET 2020


On 1/9/20 1:02 PM, Masahiro Yamada wrote:
> The "nand_x" and "ecc" clocks are currently optional. Make the core
> clock optional in the same way. This will allow platforms with no clock
> driver support to use this driver.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> 
>  drivers/mtd/nand/raw/denali_dt.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c
> index 0ce81324b90e..b1e14982c443 100644
> --- a/drivers/mtd/nand/raw/denali_dt.c
> +++ b/drivers/mtd/nand/raw/denali_dt.c
> @@ -91,7 +91,7 @@ static int denali_dt_probe(struct udevice *dev)
>  	if (ret)
>  		ret = clk_get_by_index(dev, 0, &clk);
>  	if (ret)
> -		return ret;
> +		clk.dev = NULL;
>  
>  	ret = clk_get_by_name(dev, "nand_x", &clk_x);
>  	if (ret)
> @@ -101,9 +101,11 @@ static int denali_dt_probe(struct udevice *dev)
>  	if (ret)
>  		clk_ecc.dev = NULL;
>  
> -	ret = clk_enable(&clk);
> -	if (ret)
> -		return ret;
> +	if (clk.dev) {
> +		ret = clk_enable(&clk);
> +		if (ret)
> +			return ret;
> +	}
>  
>  	if (clk_x.dev) {
>  		ret = clk_enable(&clk_x);
> 

Why do we need any of the clock code if the clock aren't available ? It
just takes space for no reason.


More information about the U-Boot mailing list