[PATCH 2/3] mtd: rawnand: denali: Allow operation without clock driver

Marek Vasut marex at denx.de
Thu Jan 9 14:21:11 CET 2020


On 1/9/20 1:04 PM, Masahiro Yamada wrote:
> On Thu, Jan 9, 2020 at 8:16 PM Marek Vasut <marex at denx.de> wrote:
>>
>> On 1/9/20 12:02 PM, Masahiro Yamada wrote:
>>> On Thu, Jan 9, 2020 at 7:08 PM Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> The SoCFPGA Gen5 does not have a clock driver yet, let the NAND driver
>>>> work without a clock driver by falling back to the default frequencies.
>>>>
>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>>>
>>>
>>> Why do you need this?
>>>
>>> denali_dt_probe() succeeds without CONFIG_CLK, doesn't it?
>>
>> No, if you don't have the NAND clock, this fails.
>> This could be reverted once there is DM/DT capable clock driver for
>> SoCFPGA Gen5, until then this is needed.
> 
> Oh, sorry, I read the code in a wrong way.
> But, this ifdef is ugly.
> 
> How about this alternative one?
> http://patchwork.ozlabs.org/patch/1220337/

The clock code takes space for no reason in that patch, I prefer this
one to keep the size in check.


More information about the U-Boot mailing list