[PATCH] net: eth-uclass: Do not return error when no MAC is found

Fabio Estevam festevam at gmail.com
Thu Jan 9 19:28:02 CET 2020


On some i.MX8QXP MEK boards with no MAC address stored, the following
hang is seen:

Error: ethernet at 5b040000 address not set.

(Board hangs)

One way to avoid this issue is to select CONFIG_NET_RANDOM_ETHADDR, so
that a random MAC is provided and boot proceeds, but the lack of MAC
should not hang the entire system.

Fix the hang by removing the propagation of error when no MAC is found.

In this case there are already messages indicating that something
is not correct:

Error: ethernet at 5b040000 address not set.

Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value
eth0: ethernet at 5b040000
Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value

Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
 net/eth-uclass.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index ed81cbd537..bc2b0aac00 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -554,7 +554,6 @@ static int eth_post_probe(struct udevice *dev)
 #else
 		printf("\nError: %s address not set.\n",
 		       dev->name);
-		return -EINVAL;
 #endif
 	}
 
-- 
2.17.1



More information about the U-Boot mailing list