[EXT] Re: [Patch v3 1/7] spi: Transform the FSL QuadSPI driver to use the SPI MEM API

[Kuldeep Singh]

> -----Original Message-----
> From: Schrempf Frieder <frieder.schrempf at kontron.de>
> Sent: Tuesday, January 7, 2020 4:39 PM
> To: Kuldeep Singh <kuldeep.singh at nxp.com>; u-boot at lists.denx.de;
> jagan at amarulasolutions.com; Vignesh R <vigneshr at ti.com>; Jagan Teki
> <jagan at openedev.com>
> Cc: Priyanka Jain <priyanka.jain at nxp.com>; Ashish Kumar
> <ashish.kumar at nxp.com>; Stefan Roese <sr at denx.de>
> Subject: [EXT] Re: [Patch v3 1/7] spi: Transform the FSL QuadSPI driver to use
> the SPI MEM API
> 
> Caution: EXT Email
> 
> Hi Kuldeep,
> 
> On 06.01.20 11:56, Kuldeep Singh wrote:
> > Hi Jagan and Vignesh,
> >
> > Could you please review this driver. Actually, I don't want to miss this merge
> window.
> > Moreover, Frieder's suggestions are already incorporated and this version
> of driver is almost identical to linux version apart from the changes already
> mentioned in commit message.
> > You may also take a look at Linux driver[1] as well.
> 
> As the v3 is close to my original version and the Linux version, I'm ok
> with it. I can't review my own patch but from my point of once the two
> dependencies are merged, this could be merged too.
> 
> As for the other (cleanup) patches in this series, have you tested them
> with buildman to make sure the config changes are ok?

Thanks for pointing it out Frieder.
I have checked with buildman and found one board failing in cleaning up patches.
I will correct it and post next version.

Thanks
Kuldeep

> Thanks,
> Frieder
> 
> >
> > P.S: Jagan, I was not sure which email you use frequently. So, I tagged both
> of them.
> >
> > Thanks
> > Kuldeep
> >
> > [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.
> bootlin.com%2Flinux%2Flatest%2Fsource%2Fdrivers%2Fspi%2Fspi-fsl-
> qspi.c&data=02%7C01%7Ckuldeep.singh%40nxp.com%7C51143fbfadc54
> 366357f08d793621657%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C637139921811229018&sdata=EZY5AKZVYZl%2ByrovsgGS9FJBGuxryI
> aCwRLX4UHSZFU%3D&reserved=0
<snip>