[PATCH 3/5] ARM: stm32: Fill in missing loadaddr

[Patrick DELAUNAY]

Hi Marek,

> From: Marek Vasut <marex at denx.de>
> Sent: vendredi 10 janvier 2020 01:29
> 
> Since CONFIG_LOADADDR is not set, the default value of $loadaddr variable is
> not set in the environment either. Set the default load address to 256 MiB from the
> start of DRAM.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> Cc: Patrice Chotard <patrice.chotard at st.com>
> ---
>  include/configs/stm32mp1.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h index
> 655833428e..b23dd38794 100644
> --- a/include/configs/stm32mp1.h
> +++ b/include/configs/stm32mp1.h
> @@ -36,6 +36,7 @@
>   * Needed by "loadb"
>   */
>  #define CONFIG_SYS_LOAD_ADDR			STM32_DDR_BASE
> +#define CONFIG_LOADADDR				0xd0000000

A offset a 256 MiB is really huge... 
And I don't sure that will fit all the commands (bootm with zImage
as it is xpecting to be placed in the first 128 MiB of RAM) and all the products
(with lower memory)

I propose to have the same value for the 2 defines which define the default loadaddr
with 32MB offset (same value that kernel_addr_r).

in stm32mp1.h, the defines becomes:

/*
 * default load address used for command tftp,  bootm , loadb, ...
 */
#define CONFIG_LOADADDR			0xc2000000
#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 

Regards
Patrick