[PATCH 3/3] riscv: sifive: fu540: add SPL configuration

[Pragnesh Patel]

>-----Original Message-----
>From: Amit Tomer <amittomer25 at gmail.com>
>Sent: 31 December 2019 22:49
>To: Pragnesh Patel <pragnesh.patel at sifive.com>
>Cc: U-Boot <u-boot at lists.denx.de>; Palmer Dabbelt ( Sifive)
><palmer at sifive.com>; Atish Patra <atish.patra at wdc.com>; Alexander Graf
><agraf at csgraf.de>; Boris Brezillon <bbrezillon at kernel.org>
>Subject: Re: [PATCH 3/3] riscv: sifive: fu540: add SPL configuration
>
>Hi Pragnesh,
>
>Minor comments regarding coding style, see below.
>
>> +       // Probably don't need to do this, since
>> +       // all the other stuff has been happening.
>> +       // But it is on the wave form.
>
>U-boot is mostly implemented in C, we should *not* use C++ style
>comments(//).
>is this something picked from BSP code ?

Yes that is copied from BSP, I will update this in v2, thanks for highlighting this.

>
>> +#include "include/ccache.h"
>> +#include "include/fu540-memory-map.h"
>
>This looks bit strange, I mean the double include above

This "fu540/include" directory is specifically for SPL, I will rename it in v2 patch.

>
>> +// Inlining header functions in C
>> +// https://stackoverflow.com/a/23699777/7433423
>
>This could be conveyed in comments rather then pointing some external link.

Will remove the external link and add inline comments for that, thanks for the review.

>
>Thanks
>-Amit.