[RFC PATCH] imx: imx8mm-evk/imx8mn-evk: enable sysreset driver for SPL

Marek Vasut marex at denx.de
Sun Jan 19 15:10:39 CET 2020


On 1/19/20 8:48 AM, Peng Fan wrote:
[...]

>>>> Because, I believe we can both agree that dumping such ad-hoc code
>>>> which implements reset in board code is not the right way, esp.
>>>> nowadays with all the DM/DT stuff in.
>>>
>>> Alought we still have ocram space, but our SPL is huge now, 100KB+
>>
>> How so ?
>>
>> How much does DM sysreset add to that ?
> 
> currently I am a bit hesitated about DM SPL,
> but it let us not to maintain two drivers for one module.
> Just some complaining words:)
> I am fine to add DM sysreset currently.
> Not sure how much it will add after DM usb.

I have two things to say about this.
1) I share your concern about DM SPL, we have a massive size problem.
   Thus far, we don't have a solution. Patches welcome. One option
   might be to optimize out frameworks which only have one driver
   instance in SPL, like MMC_TINY does and have subsystem API directly
   call that one driver instance.
2) Hacking ad-hoc drivers in board/ files is broken design, so we need a
   solution, which does not do that. If we want to disregard DM sysreset
   in SPL for this board, we can only do that based on hard numbers,
   that is, measure the size impact and determine if that's an issue. If
   so, we need another solution. Otherwise, we enable DM sysreset and
   go back to solving 1) as a separate topic.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list