[PATCH] genboardscfg.py: fix python version dependency comment

Baruch Siach baruch at tkos.co.il
Tue Jan 21 16:48:07 CET 2020


Hi Masahiro Yamada,

On Wed, Jan 22, 2020 at 12:19:31AM +0900, Masahiro Yamada wrote:
> On Mon, Jan 20, 2020 at 9:08 PM Baruch Siach <baruch at tkos.co.il> wrote:
> >
> > genboardscfg.py requires python 3.x since commit 3bc14098d8fb
> > ("genboardscfg.py: Convert to Python 3").
> >
> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> > ---
> >  tools/genboardscfg.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py
> > index 24df13e5008d..0c3c8ff403d0 100755
> > --- a/tools/genboardscfg.py
> > +++ b/tools/genboardscfg.py
> > @@ -11,7 +11,7 @@ Run 'tools/genboardscfg.py' to create a board database.
> >
> >  Run 'tools/genboardscfg.py -h' for available options.
> >
> > -Python 2.6 or later, but not Python 3.x is necessary to run this script.
> > +Python 3.x is necessary to run this script.
> 
> 
> An exact version number ("Python 3.0" if it works)
> would be more helpful.
> 
> I do not know the number, though...

My neither. The shebang mentions python3 specifically, so I'm not sure this 
comment is all that useful. How about we remove the python version comment 
entirely?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the U-Boot mailing list