[PATCH 1/1 v1] cmd: gpio: Correct do_gpio() return value

Tom Rini trini at konsulko.com
Thu Jan 23 13:31:38 CET 2020


On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:

> Use the correct return value in function do_gpio() and update
> commands documentation with the return values from command_ret_t enum.
> 
> CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
> returned on command failure.
> 
> The command was returning the pin value, which caused confusion when
> debugging (#define DEBUG).
> 
> Signed-off-by: Luka Kovacic <luka.kovacic at sartura.hr>
> Tested-by: Robert Marko <robert.marko at sartura.hr>

So, I think the problem is that despite this not being an optimal user
interface, it's what we've had here for "forever".  We can't just go
change it now as there's scripts out in the world (and even
include/configs/) that depend on the current behavior.  Sorry, nak.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200123/30c34a37/attachment.sig>


More information about the U-Boot mailing list