[PATCH 1/1 v1] cmd: gpio: Correct do_gpio() return value

[Tom Rini]

On Thu, Jan 23, 2020 at 10:04:05PM +0100, Luka Kovačič wrote:

> Hello Tom,
> 
> thank you for feedback and review. I understand the implications.
> Would it make sense to document this somewhere to avoid any future confusion?

Yes, along with a standalone patch to update the document to use
CMD_RET_SUCCESS NOT CMD_SUCCESS.  Updating the gpio help text even to be
clear what the return value is would be nice.  Thanks!

> 
> Thanks,
> Luka
> 
> On Thu, Jan 23, 2020 at 1:31 PM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
> >
> > > Use the correct return value in function do_gpio() and update
> > > commands documentation with the return values from command_ret_t enum.
> > >
> > > CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
> > > returned on command failure.
> > >
> > > The command was returning the pin value, which caused confusion when
> > > debugging (#define DEBUG).
> > >
> > > Signed-off-by: Luka Kovacic <luka.kovacic at sartura.hr>
> > > Tested-by: Robert Marko <robert.marko at sartura.hr>
> >
> > So, I think the problem is that despite this not being an optimal user
> > interface, it's what we've had here for "forever".  We can't just go
> > change it now as there's scripts out in the world (and even
> > include/configs/) that depend on the current behavior.  Sorry, nak.
> >
> > --
> > Tom

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200123/85527a31/attachment.sig>