[PATCH] video: mxsfb: call remove() when booting OS

[Fabio Estevam]

Hi Anatolij,

On Sat, Jan 25, 2020 at 7:44 PM Anatolij Gustschin <agust at denx.de> wrote:
>
> Add DM_FLAG_OS_PREPARE flag to ensure that the driver's
> remove() callback is invoked before booting the kernel.
> This is required to stop the LCDIF controller. This was
> the behaviour with old driver without DM_VIDEO support.
> Without stopping the LCDIF we sometimes observe incorrect
> Linux logo position.
>
> Fixes: ae0760584b38 ("imx: mx6ul_14x14_evk: convert to DM_VIDEO")
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> Reported-by: Fabio Estevam <festevam at gmail.com>
> ---
>  drivers/video/mxsfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index c52981053e..c097682d00 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -429,6 +429,6 @@ U_BOOT_DRIVER(mxs_video) = {
>         .bind   = mxs_video_bind,
>         .probe  = mxs_video_probe,
>         .remove = mxs_video_remove,
> -       .flags  = DM_FLAG_PRE_RELOC,
> +       .flags  = DM_FLAG_PRE_RELOC | DM_FLAG_OS_PREPARE,

Thanks! This fixes the Linux logo shift issue:

Reviewed-by: Fabio Estevam <festevam at gmail.com>

One thing I noticed is that after this patch we get a white screen
during U-Boot handoff until the kernel logo is shown.

This was not observed with the non DM driver.

Is there a way we could keep the screen black instead of white during
the transition?

Thanks