[PATCH] optee: Replace uninitialized return variable by proper one.

Heiko Stuebner heiko.stuebner at theobroma-systems.com
Mon Jan 27 08:05:03 CET 2020


Am Sonntag, 26. Januar 2020, 23:20:54 CET schrieb Christoph Müllner:
> As hinted by GCC 9, there is a return statement that returns
> an uninitialized variable in optee_copy_firmware_node().
> This patch addresses this.
> 
> Signed-off-by: Christoph Müllner <christoph.muellner at theobroma-systems.com>

Thanks for catching this mistake of mine
Reviewed-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>


> 
> ---
> 
>  lib/optee/optee.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/optee/optee.c b/lib/optee/optee.c
> index 9b49eb8ee7..d4355c6d03 100644
> --- a/lib/optee/optee.c
> +++ b/lib/optee/optee.c
> @@ -92,7 +92,7 @@ static int optee_copy_firmware_node(const void *old_blob, void *fdt_blob)
>  
>  	offs = fdt_add_subnode(fdt_blob, offs, "optee");
>  	if (offs < 0)
> -		return ret;
> +		return offs;
>  
>  	/* copy the compatible property */
>  	prop = fdt_getprop(old_blob, old_offs, "compatible", &len);
> 






More information about the U-Boot mailing list