[PATCH v4 01/10] env: nowhere: set default enviroment

[Keerthy]

On 27/01/20 7:42 pm, Tom Rini wrote:
> On Mon, Jan 27, 2020 at 02:34:17PM +0100, Wolfgang Denk wrote:
>> Dear Keerthy,
>>
>> In message <f93caaca-f041-a6fb-2a09-d588451d854c at ti.com> you wrote:
>>>
>>>>> Set default enviroment so that set_env calls succeed when only
>>>>> ENV_IS_NOWHERE set.
>>>>>
>>>>> Signed-off-by: Keerthy <j-keerthy at ti.com>
>>>>> ---
>>>>>
>>>>> Changes in v4:
>>>>>
>>>>>     * Reworded commit log
>>>>>
>>>>>    env/nowhere.c | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/env/nowhere.c b/env/nowhere.c
>>>>> index f5b0a17652..70c3b3e011 100644
>>>>> --- a/env/nowhere.c
>>>>> +++ b/env/nowhere.c
>>>>> @@ -23,6 +23,7 @@ static int env_nowhere_init(void)
>>>>>    {
>>>>>    	gd->env_addr	= (ulong)&default_environment[0];
>>>>>    	gd->env_valid	= ENV_INVALID;
>>>>> +	(NULL, 0);
>>
>> ^^^^^^^^^^^^^^^^^^^^^^
>> You are inserting this line of "C code" only.
> 
> I think something got ate along the way.  The patch is at
> http://patchwork.ozlabs.org/patch/1226946/
> and the full line is:
> +	env_set_default(NULL, 0);

Thanks Tom.

Wolfgang,

env_set_default(NULL, 0); sets the required flag for us in the nowhere 
path as well.

That enabled set_env.

Thanks,
Keerthy

> 
>