[PATCH v2 3/4] mtd: rawnand: denali_dt: use UCLASS_MTD instead of UCLASS_MISC

[Marek Vasut]

On 1/29/20 6:08 PM, Simon Goldschmidt wrote:
> Am 29.01.2020 um 16:55 schrieb Masahiro Yamada:
>> UCLASS_MTD is a better fit for NAND drivers.
>>
>> Make NAND_DENALI_DT depend on DM_MTD, which is needed to compile
>> drivers/mtd/mtd-uclass.c
>>
>> Also, make ARCH_SOCFPGA and ARCH_UNIPHIER select DM_MTD because
>> they use this driver.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>> ---
>>
>> Changes in v2:
>>   - new patch
>>
>>   arch/arm/Kconfig                 | 2 ++
>>   drivers/mtd/nand/raw/Kconfig     | 2 +-
>>   drivers/mtd/nand/raw/denali_dt.c | 4 ++--
>>   3 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 1236315168..d1c58667c7 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -935,6 +935,7 @@ config ARCH_SOCFPGA
>>       select ARM64 if TARGET_SOCFPGA_STRATIX10 || TARGET_SOCFPGA_AGILEX
>>       select CPU_V7A if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
>>       select DM
>> +    select DM_MTD
> 
> Does any socfpga actually enable the denali driver? Do we need to
> default to this instead of enabling it in a defconfig?
> 
> If we need it, could you please change that to 'imply'? Not all configs
> will need this.

No SoCFPGA enables the Denali NAND, because support for that was
completely broken and I was waiting until the Denali NAND patches make
it in before sending that platform which will use it.

Indeed, DM_MTD should be enabled in platform config, not in general.