[PATCH] riscv: Remove unnecessary instruction

Rick Chen rickchen36 at gmail.com
Thu Jan 30 08:35:29 CET 2020


> From: Sean Anderson [mailto:seanga2 at gmail.com]
> Sent: Tuesday, January 28, 2020 5:40 AM
> To: U-Boot Mailing List
> Cc: Bin Meng; Lukas Auer; Anup.Patel at wdc.com; Rick Jian-Zhi Chen(陳建志)
> Subject: [PATCH] riscv: Remove unnecessary instruction
>
> The add instruction on risc-v can have any three sources and targets, so there is no need for an intermediate mov.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>

Reviewed-by: Rick Chen <rick at andestech.com>

> ---
>  arch/riscv/cpu/start.S | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 1a55b7d570..365163ad19 100644
> --- a/arch/riscv/cpu/start.S
> +++ b/arch/riscv/cpu/start.S
> @@ -359,9 +359,8 @@ relocate_secondary_harts:
>  call_board_init_r:
>         jal     invalidate_icache_all
>         jal     flush_dcache_all
> -       la      t0, board_init_r
> -       mv      t4, t0                  /* offset of board_init_r() */
> -       add     t4, t4, t6              /* real address of board_init_r() */
> +       la      t0, board_init_r        /* offset of board_init_r() */
> +       add     t4, t0, t6              /* real address of board_init_r() */
>  /*
>   * setup parameters for board_init_r
>   */
> --


More information about the U-Boot mailing list