Antwort: Re: [RFC PATCH 3/4] x86: Move itss.c from Apollo Lake to a more generic location

[Wolfgang Wallner]

Hello Simon,

-----"Simon Glass" <sjg at chromium.org> schrieb: -----
> On Wed, 22 Jan 2020 at 08:01, Wolfgang Wallner
> <wolfgang.wallner at br-automation.com> wrote:
> >
> > The Interrupt Timer Subsystem (ITSS) is not specific to Apollo Lake, so
> > move it to a common location within arch/x86.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> > ---
> > At the moment, this commit enables building of itss.o unconditionally.
> > which is a bad idea I guess.
> > What is the preferred way to handle this?
> > Should I add a kconfig option e.g. in arch/x86/Kconfig?

Thank you for reviewing.

But I'm still not sure how to handle the question mentioned above, and
would like to ask for further feedback.

My current idea would be to add a new kconfig option CONFIG_ITSS in
arch/x86/Kconfig to control building of this driver (which would be
automatically implied via 'select' when the build target is Apollo Lake).

Does that make sense? If so, I would include the necessary modifications
to kconfig in the next version of this patch.

> >
> >  arch/x86/cpu/apollolake/Makefile                 | 1 -
> >  arch/x86/cpu/intel_common/Makefile               | 1 +
> >  arch/x86/cpu/{apollolake => intel_common}/itss.c | 0
> >  3 files changed, 1 insertion(+), 1 deletion(-)
> >  rename arch/x86/cpu/{apollolake => intel_common}/itss.c (100%)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>


regards, Wolfgang