[U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

Wolfgang Denk wd at denx.de
Fri Jan 31 14:47:37 CET 2020


Dear Simon,

In message <11b25950-50a3-c9cd-3c2d-5b2d6583046b at gmail.com> you wrote:
>
> Hm, U-Boot's 'hsearch_r' does not conform to this 'standard' since 
> December 2012, see these 2 commits from 2012 and 2019:

Argh.  What shall I say... this should get fixed ?

> Obviously, my comments have no real relation to the intention of the 
> patch to 'clean up' things. I do think the current situation could be 
> improved (e.g. regarding constness), but looking at the nonchalant way 
> such a 'standard' function has been change nonstandard, I think this 
> should be a change we actively vote for (and the above 2 patches did not 
> seem to take this into account).

Indeed.  I'm pretty sure I did not notice these.

Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where people stand is not as important as which way they face.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_


More information about the U-Boot mailing list