[PATCH v2 15/28] fs/squashfs: sqfs_read: fix memory leak

[João Marcos Costa]

Reviewed-by Joao Marcos Costa <jmcosta944 at gmail.com>

Em ter., 3 de nov. de 2020 às 08:12, Richard Genoud <
richard.genoud at posteo.net> escreveu:

> sqfs_closedir() should be called to free memory allocated by
> sqfs_opendir()
>
> Signed-off-by: Richard Genoud <richard.genoud at posteo.net>
> ---
>  fs/squashfs/sqfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index 1ac07625889..a9e803cbac2 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -1341,7 +1341,6 @@ int sqfs_read(const char *filename, void *buf,
> loff_t offset, loff_t len,
>         if (ret) {
>                 printf("File not found.\n");
>                 *actread = 0;
> -               sqfs_closedir(dirsp);
>                 ret = -ENOENT;
>                 goto free_paths;
>         }
> @@ -1532,6 +1531,7 @@ free_datablk:
>  free_paths:
>         free(file);
>         free(dir);
> +       sqfs_closedir(dirsp);
>
>         return ret;
>  }
>


-- 
Atenciosamente,
João Marcos Costa

www.linkedin.com/in/jmarcoscosta/
https://github.com/jmarcoscosta