[PATCH v2 18/28] fs/squashfs: sqfs_get_abs_path: fix error check

João Marcos Costa jmcosta944 at gmail.com
Tue Nov 3 13:44:31 CET 2020


Reviewed-by Joao Marcos Costa <jmcosta944 at gmail.com>

Em ter., 3 de nov. de 2020 às 08:12, Richard Genoud <
richard.genoud at posteo.net> escreveu:

> the return value of sqfs_tokenize(rel_tokens, rc, rel); wasn't checked.
> (but "ret" value was !)
> This is obviouly a typo.
>
> Signed-off-by: Richard Genoud <richard.genoud at posteo.net>
> ---
>  fs/squashfs/sqfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index b97a961c5e3..825d5d13fa2 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -359,7 +359,7 @@ static char *sqfs_get_abs_path(const char *base, const
> char *rel)
>         if (ret)
>                 goto free_r_tokens;
>
> -       sqfs_tokenize(rel_tokens, rc, rel);
> +       ret = sqfs_tokenize(rel_tokens, rc, rel);
>         if (ret)
>                 goto free_r_tokens;
>
>

-- 
Atenciosamente,
João Marcos Costa

www.linkedin.com/in/jmarcoscosta/
https://github.com/jmarcoscosta


More information about the U-Boot mailing list